This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Don't skip RDNs when reading from LDAP. Just treat them like normal attributes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttributes. Skipping RDNs was causing 'terraform apply' to always attempt to add the RDN attribute. And when terraform attempted to add the RDN attribute, the ldap server would complain that the attribute already existed. I didn't see a reason why RDNs should be skipped when reading from LDAP, so I just removed the the logic to skip them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #7
Skipping RDNs was causing 'terraform apply' to always attempt to add the RDN attribute for existing entries.
And when terraform attempted to add the RDN attribute, the ldap server would complain that the attribute already existed.
I didn't see a reason why RDNs should be skipped when reading from LDAP,
so I just removed the the logic to skip them.